Am 23.02.23 um 00:42 schrieb Christoph Hellwig:
On Wed, Feb 22, 2023 at 02:58:28PM -0700, Jonathan Derrick wrote:+ if (io_size != opt_size && + start + opt_size / SECTOR_SIZE <= boundary) + return opt_size; + else if (start + io_size / SECTOR_SIZE <= boundary)No need for an else after a return. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
the "return" is within the if-condition and has nothing to do with the else - with {} it would be clearly visible
