Re: [PATCH] mdadm: block update=ppl for non raid456 levels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/15/22 08:28, Lukasz Florczak wrote:
> Option ppl should be used only for raid levels 4, 5 and 6. Cancel update
> for other levels.
> 
> Applied globally for imsm and ddf format.
> 
> Additionally introduce is_level456() helper function.
> 
> Signed-off-by: Lukasz Florczak <lukasz.florczak@xxxxxxxxxxxxxxx>
> ---
>  Assemble.c | 11 +++++------
>  Grow.c     |  2 +-
>  Manage.c   | 14 ++++++++++++--
>  mdadm.h    | 11 +++++++++++
>  super0.c   |  2 +-
>  super1.c   |  3 +--
>  6 files changed, 31 insertions(+), 12 deletions(-)

Hi Lukasz,

I like the level456 change, it really helps avoid trivial bugs. I would
have preferred this being two patches, one for the 456 change and one
for the functional change, but I still applied it.

Thanks,
Jes




[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux