On 6/6/22 11:48 PM, Logan Gunthorpe wrote:
After move "md_unregister_thread(&mddev->sync_thread)", then we need to
rename md_reap_sync_thread given it doesn't unregister sync_thread, any
suggestion about the new name? md_behind_reap_sync_thread?
I don't like the "behind"... Which would be a name suggesting when the
function should be called, not what the function does.
Right, naming is hard.
I'd maybe go with something like md_cleanup_sync_thread()
It is confusing since it doesn't related with sync_thread anymore after
the pull.
I will keep the name unchanged for now.
Thanks,
Guoqing