tree: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git test/klp-trampoline head: 6fbf5243a0d6ac55cae9ed84bb5ef0d49d1c00bc commit: 7970d53b6d04732808d677f072446b59451d032c [4/6] ftrace: introduce FTRACE_OPS_FL_SHARE_IPMODIFY config: x86_64-randconfig-c007-20220606 (https://download.01.org/0day-ci/archive/20220607/202206070722.yx7Ff8v1-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git/commit/?id=7970d53b6d04732808d677f072446b59451d032c git remote add song-md git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git git fetch --no-tags song-md test/klp-trampoline git checkout 7970d53b6d04732808d677f072446b59451d032c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): kernel/trace/ftrace.c:8004:14: error: use of undeclared identifier 'direct_mutex'; did you mean 'event_mutex'? mutex_lock(&direct_mutex); ^~~~~~~~~~~~ event_mutex include/linux/mutex.h:187:44: note: expanded from macro 'mutex_lock' #define mutex_lock(lock) mutex_lock_nested(lock, 0) ^ kernel/trace/trace.h:1523:21: note: 'event_mutex' declared here extern struct mutex event_mutex; ^ >> kernel/trace/ftrace.c:8006:14: error: no member named 'func_hash' in 'struct ftrace_ops' hash = ops->func_hash->filter_hash; ~~~ ^ >> kernel/trace/ftrace.c:8019:9: error: call to undeclared function 'ops_references_ip'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] if (ops_references_ip(op, ip)) { ^ >> kernel/trace/ftrace.c:8027:14: error: no member named 'ops_func' in 'struct ftrace_ops' if (!op->ops_func) { ~~ ^ kernel/trace/ftrace.c:8031:15: error: no member named 'ops_func' in 'struct ftrace_ops' ret = op->ops_func(op, FTRACE_OPS_CMD_ENABLE_SHARE_IPMODIFY); ~~ ^ kernel/trace/ftrace.c:8046:16: error: use of undeclared identifier 'direct_mutex'; did you mean 'event_mutex'? mutex_unlock(&direct_mutex); ^~~~~~~~~~~~ event_mutex kernel/trace/trace.h:1523:21: note: 'event_mutex' declared here extern struct mutex event_mutex; ^ kernel/trace/ftrace.c:8083:17: error: use of undeclared identifier 'direct_mutex'; did you mean 'event_mutex'? mutex_unlock(&direct_mutex); ^~~~~~~~~~~~ event_mutex kernel/trace/trace.h:1523:21: note: 'event_mutex' declared here extern struct mutex event_mutex; ^ 7 errors generated. vim +8006 kernel/trace/ftrace.c 7973 7974 /* 7975 * When registering ftrace_ops with IPMODIFY (not direct), it is necessary 7976 * to make sure it doesn't conflict with any direct ftrace_ops. If there is 7977 * existing direct ftrace_ops on a kernel function being patched, call 7978 * FTRACE_OPS_CMD_ENABLE_SHARE_IPMODIFY on it to enable sharing. 7979 * 7980 * @ops: ftrace_ops being registered. 7981 * 7982 * Returns: 7983 * 0 - @ops does have IPMODIFY or @ops itself is DIRECT, no change 7984 * needed; 7985 * 1 - @ops has IPMODIFY, hold direct_mutex; 7986 * -EBUSY - currently registered DIRECT ftrace_ops does not support 7987 * SHARE_IPMODIFY, we need to abort the register. 7988 * -EAGAIN - cannot make changes to currently registered DIRECT 7989 * ftrace_ops at the moment, but we can retry later. This 7990 * is needed to avoid potential deadlocks. 7991 */ 7992 static int prepare_direct_functions_for_ipmodify(struct ftrace_ops *ops) 7993 __acquires(&direct_mutex) 7994 { 7995 struct ftrace_func_entry *entry; 7996 struct ftrace_hash *hash; 7997 struct ftrace_ops *op; 7998 int size, i, ret; 7999 8000 if (!(ops->flags & FTRACE_OPS_FL_IPMODIFY) || 8001 (ops->flags & FTRACE_OPS_FL_DIRECT)) 8002 return 0; 8003 8004 mutex_lock(&direct_mutex); 8005 > 8006 hash = ops->func_hash->filter_hash; 8007 size = 1 << hash->size_bits; 8008 for (i = 0; i < size; i++) { 8009 hlist_for_each_entry(entry, &hash->buckets[i], hlist) { 8010 unsigned long ip = entry->ip; 8011 bool found_op = false; 8012 8013 mutex_lock(&ftrace_lock); 8014 do_for_each_ftrace_op(op, ftrace_ops_list) { 8015 if (!(op->flags & FTRACE_OPS_FL_DIRECT)) 8016 continue; 8017 if (op->flags & FTRACE_OPS_FL_SHARE_IPMODIFY) 8018 break; > 8019 if (ops_references_ip(op, ip)) { 8020 found_op = true; 8021 break; 8022 } 8023 } while_for_each_ftrace_op(op); 8024 mutex_unlock(&ftrace_lock); 8025 8026 if (found_op) { > 8027 if (!op->ops_func) { 8028 ret = -EBUSY; 8029 goto err_out; 8030 } 8031 ret = op->ops_func(op, FTRACE_OPS_CMD_ENABLE_SHARE_IPMODIFY); 8032 if (ret) 8033 goto err_out; 8034 } 8035 } 8036 } 8037 8038 /* 8039 * Didn't find any overlap with any direct function, or the direct 8040 * function can share with ipmodify. Hold direct_mutex to make sure 8041 * this doesn't change until we are done. 8042 */ 8043 return 1; 8044 8045 err_out: 8046 mutex_unlock(&direct_mutex); 8047 return ret; 8048 -- 0-DAY CI Kernel Test Service https://01.org/lkp
