Re: [PATCH v3 7/7] tests: avoid passing chunk size to raid1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2022-05-10 11:09, himanshu.madhani@xxxxxxxxxx wrote:
> From: Sudhakar Panneerselvam <sudhakar.panneerselvam@xxxxxxxxxx>
> 
> '04update-metadata' test fails with error, "specifying chunk size is
> forbidden for this level" added by commit, 5b30a34aa4b5e. Hence,
> correcting the test to ignore passing chunk size to raid1.
> 
> Signed-off-by: Sudhakar Panneerselvam <sudhakar.panneerselvam@xxxxxxxxxx>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

[snip]

> diff --git a/tests/05r1-re-add b/tests/05r1-re-add
> index fa6bbcb421e5..12da5644dee5 100644
> --- a/tests/05r1-re-add
> +++ b/tests/05r1-re-add
> @@ -14,6 +14,7 @@ sleep 4
>  mdadm $md0 -f $dev2
>  sleep 1
>  mdadm $md0 -r $dev2
> +cat /proc/mdstat
>  mdadm $md0 -a $dev2
>  #cat /proc/mdstat
>  check nosync

This hunk doesn't seem like it should be in this patch.


In any case, I've integrated a few of your patches into my work which
fixes 4 more tests that I had previously marked as broken. Sadly I still
have 25 tests that appear to be broken in different ways which I'm
probably not going to get to myself.

The current branch is here:

https://github.com/lsgunth/mdadm bugfixes2

I'm waiting for my kernel series to be accepted into md-next before
sending these patches to the list so I can put a stable git hash of the
kernel version I tested against in the commit message of the last
commit. After that, I intend on getting back to the work I was
originally trying to do. When I do send the series I'll rebase on the
current master in case your patches have been accepted.

Thanks,

Logan



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux