On 2022-05-10 11:09, himanshu.madhani@xxxxxxxxxx wrote: > From: Sudhakar Panneerselvam <sudhakar.panneerselvam@xxxxxxxxxx> > > Some of the test cases use $dir to refer to the location of mdadm and > other test binaries. But $dir was never initialized anywhere in the test > sequence. I noticed this too in a couple tests, but IMO I'd rather see the variable removed instead of blindly fixed without specifying the effects on the tests that use it. For example, I've noticed that 07testreshape5 uses it, but once fixed, the test still fails. A bunch of 10ddf tests have it but those lines are commented out. A bunch of 19*repair tests use it but they don't seem to fail for me before the fix so there is likely some other brokenness involved. Logan
