On Wed, Apr 20, 2022 at 01:54:21PM -0600, Logan Gunthorpe wrote:
> prepare_to_wait(&conf->wait_for_overlap, &w, TASK_UNINTERRUPTIBLE);
> - for (; logical_sector < last_sector; logical_sector += RAID5_STRIPE_SECTORS(conf)) {
> - retry:
> + while (logical_sector < last_sector) {
> res = make_stripe_request(mddev, conf, &ctx, logical_sector,
> bi);
> if (res == STRIPE_FAIL) {
> break;
> } else if (res == STRIPE_RETRY) {
> - goto retry;
> + continue;
> } else if (res == STRIPE_SCHEDULE_AND_RETRY) {
> schedule();
> prepare_to_wait(&conf->wait_for_overlap, &w,
> TASK_UNINTERRUPTIBLE);
> - goto retry;
> + continue;
> }
All the else statements here aren't needed (this is really a
comment for the earlier patch adding them).
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
