> + if (unlikely(conf->reshape_progress != MaxSector)) { > + /* spinlock is needed as reshape_progress may be Normal kernel style is to stat with a /* line and to captalize the first word. (also applies for a few other comments). > + if (must_retry) { > + raid5_release_stripe(sh); > + return STRIPE_SCHEDULE_AND_RETRY; The raid5_release_stripe cleanup is duplicated a few times. I think using goto based unwinding would be hepful in this function.