On 9/22/21 11:38 AM, Song Liu wrote: > > >> On Sep 22, 2021, at 9:14 AM, Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> On 9/22/21 10:10 AM, Song Liu wrote: >>> Hi Jens, >>> >>> Please consider pulling the following changes for md-fixes on top of your >>> block-5.15 branch. The changes are: >>> 1. Fix lock order reversal in md_alloc. (Christoph) >>> 2. Handle add_disk error in md_alloc. (Luis) >>> 3. Refactor md sysfs attrs, included because of dependency with 1 and 2. >>> (Christoph). >> >> I don't think the error handling for add_disk is prudent at this point, >> that's something that should go in with the 5.16 cycle. It's been like >> that forever, nothing that warrants pushing this for 5.15 at all. > > Hmm... I see. The WARN_ON_ONCE at the end of device_add_disk() should be > enough. We've had no error handling in add_disk forever, this is not a new issue. > Then we just need the first commit. Could you please pull the > following change instead? > > 1. Fix lock order reversal in md_alloc. (Christoph) Looks better, thanks. -- Jens Axboe
