> On Sep 22, 2021, at 9:14 AM, Jens Axboe <axboe@xxxxxxxxx> wrote: > > On 9/22/21 10:10 AM, Song Liu wrote: >> Hi Jens, >> >> Please consider pulling the following changes for md-fixes on top of your >> block-5.15 branch. The changes are: >> 1. Fix lock order reversal in md_alloc. (Christoph) >> 2. Handle add_disk error in md_alloc. (Luis) >> 3. Refactor md sysfs attrs, included because of dependency with 1 and 2. >> (Christoph). > > I don't think the error handling for add_disk is prudent at this point, > that's something that should go in with the 5.16 cycle. It's been like > that forever, nothing that warrants pushing this for 5.15 at all. Hmm... I see. The WARN_ON_ONCE at the end of device_add_disk() should be enough. Then we just need the first commit. Could you please pull the following change instead? 1. Fix lock order reversal in md_alloc. (Christoph) Thanks, Song The following changes since commit 858560b27645e7e97aca37ee8f232cccd658fbd2: blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd (2021-09-15 12:03:18 -0600) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-fixes for you to fetch changes up to 7df835a32a8bedf7ce88efcfa7c9b245b52ff139: md: fix a lock order reversal in md_alloc (2021-09-22 08:45:58 -0700) ---------------------------------------------------------------- Christoph Hellwig (1): md: fix a lock order reversal in md_alloc drivers/md/md.c | 5 ----- 1 file changed, 5 deletions(-)
