Re: [PATCH] md/raid5: reduce lock contention in read_one_chunk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 04 Jun 2021, Gal Ofri wrote:
> Just a second thought
> 
> > Since it only impacts quiesce now, I thought it'd be better to use spinlock afterall.
> > Please let me know if you think otherwise.
> Since slow path is only at quiesce, I can remove aligned_reads_lock altogether and use device_lock like before.
> What do you think ?
> 
Yes, I think you should remove aligned_read_lock.  Remove all of your
patch and just make the change I suggested.  Then, of course, review it
carefully to make sure you agree that it is correct.

Thanks
NeilBrown





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux