Re: [PATCH mdadm] Grow: be careful of corrupt dev_roles list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/25/21 8:02 PM, NeilBrown wrote:
> 
> I've seen a case where the dev_roles list of a linear array
> was corrupt.  ->max_dev was > 128 and > raid_disks, and the
> extra slots were '0', not 0xFFFE or 0xFFFF.
> 
> This caused problems when a 128th device was added.
> 
> So:
>  1/ make Grow_Add_device more robust so that if numbers
>    look wrong, it fails-safe.
> 
>  2/ make examine_super1() report details if the dev_roles
>    array is corrupt.
> 
> Signed-off-by: NeilBrown <neilb@xxxxxxx>
> ---
>  Grow.c   | 15 ++++++++++++---
>  super1.c | 48 ++++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 50 insertions(+), 13 deletions(-)
> 

Ohhh error handling!

Applied!

Thanks,
Jes





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux