On Mon, Oct 14, 2019 at 9:30 AM Song Liu <liu.song.a23@xxxxxxxxx> wrote:
>
> On Mon, Oct 14, 2019 at 2:23 AM DrYak <doktor.yak@xxxxxxxxx> wrote:
> >
> > Hello,
> >
> > I just wanted to point a small thing:
> >
> > On 2019-10-12 01:37, Song Liu wrote:
> > >
> > > David, you may consider adding "raid0.default_layout=?" to your kernel
> > > command line options.
> > >
> > > Song
> >
> > Currently there is a slight mis-match in the actual kernel module:
> > the warning message display "raid.default_layout=?" (missing zero)
> > instead of "raid0..." (how indeed it should be used).
>
> Good catch! The warning should say raid0. Let me fix it.
>
I am about to push the following patch.
Is your official name DrYak?
@Neil, could you please review this change?
Thanks,
Song
====================================================
>From ab2b8af0b8ebafe57d66f440acdf9dc9d6190556 Mon Sep 17 00:00:00 2001
From: Song Liu <songliubraving@xxxxxx>
Date: Mon, 14 Oct 2019 16:58:35 -0700
Subject: [PATCH] md/raid0: fix warning message for parameter default_layout
The message should match the parameter, i.e. raid0.default_layout.
Cc: NeilBrown <neilb@xxxxxxx>
Reported-by: DrYak <doktor.yak@xxxxxxxxx>
Signed-off-by: Song Liu <songliubraving@xxxxxx>
---
drivers/md/raid0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index f61693e59684..1e772287b1c8 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -154,7 +154,7 @@ static int create_strip_zones(struct mddev *mddev,
struct r0conf **private_conf)
} else {
pr_err("md/raid0:%s: cannot assemble multi-zone RAID0
with default_layout setting\n",
mdname(mddev));
- pr_err("md/raid0: please set raid.default_layout to 1 or 2\n");
+ pr_err("md/raid0: please set raid0.default_layout to 1 or 2\n");
err = -ENOTSUPP;
goto abort;
}
--
2.17.1
