On Thu, Aug 15, 2019 at 6:39 PM NeilBrown <neilb@xxxxxxxx> wrote: > [...] > >> Hi Nigel > >> > >> Is it better to print rdev->read_errors too? So it can know the error > >> numbers and the max nr stripes > > > > I think rdev->read_errors is more useful here. > > > > Hi Neil, > > > > I have a question for this case: this patch changes an existing pr_warn() line, > > which in theory, may break user scripts that grep for this line from dmesg. > > How much do we care about these scripts? > > I don't think we need to care about this. Kernel log message aren't > normally considered part of the ABI. > However in this case, it might actually be more readable to have just > add another line: > > md/raid:md0: 513 read_errors, > 512 stripes > md/raid:md0: Too many read errors, failing device sda1 > Thanks Neil. I like this idea. Song
