Re: [PATCH 1/1] md: return -ENODEV if rdev has no mddev assigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/11/19 00:34, Song Liu wrote>
I think we should fix this in md.c:state_store(). rdev_attr_store() applies
to all the files. Could you please look into this?

Thanks,
Song


Hi Song,
I considered changing the return code in state_store, but if we do so - it requires also changes in mdadm (to expect different errno). It will be hard to guarantee that mdadm and kernel are in sync with each other. I checked mdadm code - it looks like there are no other places that expect EBUSY to be returned from other files related to rdev - that's why I think that it is safe to change it in rdev_attr_store().

Thanks
Pawel



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux