On Fri, Mar 8, 2019 at 7:52 AM Xiao Ni <xni@xxxxxxxxxx> wrote: > > In reshape_request it already adds len to sector_nr already. It's wrong to add len to > sector_nr again after adding pages to bio. If there is bad block it can't copy one chunk > at a time, it needs to goto read_more. Now the sector_nr is wrong. It can cause data > corruption. > > Signed-off-by: Xiao Ni <xni@xxxxxxxxxx> Applied to https://github.com/liu-song-6/linux/tree/for-5.1/md-post Thanks for the fix! Song > --- > drivers/md/raid10.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c > index abb5d38..ecef42b 100644 > --- a/drivers/md/raid10.c > +++ b/drivers/md/raid10.c > @@ -4670,7 +4670,6 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, > atomic_inc(&r10_bio->remaining); > read_bio->bi_next = NULL; > generic_make_request(read_bio); > - sector_nr += nr_sectors; > sectors_done += nr_sectors; > if (sector_nr <= last) > goto read_more; > -- > 2.7.5 >
