Re: [PATCH] raid1: update one comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12 Nov 2018, Jack Wang told this:

> From: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
>
> update one comment as Neil suggested.

Not quite...

> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index d7d713b720d0..08b49bfb2b6b 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1536,7 +1536,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio,
>  
>  	r1_bio_write_done(r1_bio);
>  
> -	/* In case raid1d snuck in to freeze_array */
> +	/* In case raid1d stuck in to freeze_array */

Neil suggested

/* In case we raced with raid1d and it called freeze_array() */

Your suggested replacement is wrong (and was what he originally objected
to): sneaking in to freeze_array is not the same thing as getting stuck
in it.



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux