On Tue, Nov 20, 2018 at 4:11 PM Nick Alcock <nix@xxxxxxxxxxxxx> wrote: > > On 12 Nov 2018, Jack Wang told this: > > > From: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx> > > > > update one comment as Neil suggested. > > Not quite... > > > diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c > > index d7d713b720d0..08b49bfb2b6b 100644 > > --- a/drivers/md/raid1.c > > +++ b/drivers/md/raid1.c > > @@ -1536,7 +1536,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, > > > > r1_bio_write_done(r1_bio); > > > > - /* In case raid1d snuck in to freeze_array */ > > + /* In case raid1d stuck in to freeze_array */ > > Neil suggested > > /* In case we raced with raid1d and it called freeze_array() */ > > Your suggested replacement is wrong (and was what he originally objected > to): sneaking in to freeze_array is not the same thing as getting stuck > in it. Oh, sorry for mess up -.- Just ignore it. -- Jack Wang Linux Kernel Developer 1&1 IONOS Cloud GmbH | Greifswalder Str. 207 | 10405 Berlin | Germany Phone: +49 30 57700-8042 | Fax: +49 30 57700-8598 E-mail: jinpu.wang@xxxxxxxxxxxxxxx | Web: www.ionos.de Head Office: Berlin, Germany District Court Berlin Charlottenburg, Registration number: HRB 125506 B Executive Management: Christoph Steffens, Matthias Steinberg, Achim Weiss Member of United Internet This e-mail may contain confidential and/or privileged information. If you are not the intended recipient of this e-mail, you are hereby notified that saving, distribution or use of the content of this e-mail in any way is prohibited. If you have received this e-mail in error, please notify the sender and delete the e-mail.
