On Tue, Nov 6, 2018 at 12:43 AM NeilBrown <neilb@xxxxxxxx> wrote: > > On Mon, Nov 05 2018, Gioh Kim wrote: > > > Before updating superblock of slave disks, desired_state value > > is set for the target state of the slave disks. But it forgets > > to check MD_DISK_FAILFAST flag. Then start_arrays() calls > > ADD_NEW_DISK ioctl-call and pass the state without MD_DISK_FAILFAST. > > > > Currenlty it does not generate any problem because kernel does not > > care MD_DISK_FAILFAST flag. > > > > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxxx> > > --- > > Assemble.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Assemble.c b/Assemble.c > > index a79466c..fc0d464 100644 > > --- a/Assemble.c > > +++ b/Assemble.c > > @@ -1704,6 +1704,9 @@ try_again: > > else > > desired_state = (1<<MD_DISK_ACTIVE) | (1<<MD_DISK_SYNC); > > > > + if (devices[j].i.disk.state & (1<<MD_DISK_FAILFAST)) > > + desired_state |= (1<<MD_DISK_FAILFAST); > > + > > if (!devices[j].uptodate) > > continue; > > > > This looks right, but I think we should preserve MD_DISK_WRITEMOSTLY as > well. > So maybe > desired_state |= devices[j].i.disk_state & ((1<<MD_DISK_FAILFAST) | > (1<<MD_DISK_WRITEMOSTLY)); Hi Neil, I will send the second patch. Thank you. > > NeilBrown > > > -- > > 2.14.1 -- GIOH KIM Linux Kernel Entwickler 1&1 IONOS Cloud GmbH Greifswalder Str. 207 D - 10405 Berlin Tel: +49 176 2697 8962 Fax: +49 30 577 008 299 Email: gi-oh.kim@xxxxxxxxxxxxxxx URL: https://www.ionos.com Sitz der Gesellschaft: Berlin Registergericht: Amtsgericht Charlottenburg, HRB 125506 B Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
