Re: [PATCH] mdadm: set persistent sync_speed_max based on rotational attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all, just posted a potential alternative for review.  Please have a
look at your convenience.
3bd19b9ba753 ("md: allow faster resync only on non-rotational media")

On Wed, Mar 28, 2018 at 3:03 PM, John Pittman <jpittman@xxxxxxxxxx> wrote:
> Xiao, the patch did not make a difference in this case.
>
>   18:18:50,392 INFO anaconda: Creating disklabel on /dev/sdb
>   18:18:50,474 INFO anaconda: Created disklabel on /dev/sdb
>   ...snip
>   18:43:14,272 INFO anaconda: Creating swap on /dev/md/3
>   18:43:32,004 INFO anaconda: Created swap on /dev/md/3
>
>
>
> On Wed, Mar 28, 2018 at 3:41 AM, Xiao Ni <xni@xxxxxxxxxx> wrote:
>>
>>
>> ----- Original Message -----
>>> From: "John Pittman" <jpittman@xxxxxxxxxx>
>>> To: "Jes Sorensen" <jes.sorensen@xxxxxxxxx>
>>> Cc: "Xiao Ni" <xni@xxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, "Shaohua Li" <shli@xxxxxxxxxx>, rm@xxxxxxxxxxx
>>> Sent: Wednesday, March 28, 2018 2:49:46 AM
>>> Subject: Re: [PATCH] mdadm: set persistent sync_speed_max based on rotational attribute
>>>
>>> Jes, Roman, et al. sorry for the wait.  I have been able to test this
>>> further and the patch mentioned was indeed causing the issue.  The
>>> easiest way for me to reproduce was by installing to a md device while
>>> it syncs.  The interesting/telling part is during
>>> partitioning/formatting.  Below is prior to reverting the patch.
>>>
>>>   19:58:39,249 INFO anaconda: Creating disklabel on /dev/sdb
>>>   19:58:39,312 INFO anaconda: Created disklabel on /dev/sdb
>>>   19:58:39,553 INFO anaconda: Creating mdmember on /dev/sdb1
>>>   19:58:39,616 INFO anaconda: Created mdmember on /dev/sdb1
>>>   19:58:40,529 INFO anaconda: Creating mdmember on /dev/sdb5
>>>   19:58:40,619 INFO anaconda: Created mdmember on /dev/sdb5
>>>   19:58:40,642 INFO anaconda: Creating mdmember on /dev/sdb3
>>>   19:58:40,708 INFO anaconda: Created mdmember on /dev/sdb3
>>>   19:58:40,731 INFO anaconda: Creating mdmember on /dev/sdb2
>>>   19:58:40,801 INFO anaconda: Created mdmember on /dev/sdb2
>>>   19:58:40,822 INFO anaconda: Creating disklabel on /dev/sda
>>>   19:58:40,890 INFO anaconda: Created disklabel on /dev/sda
>>>   19:58:41,118 INFO anaconda: Creating mdmember on /dev/sda1
>>>   19:58:41,179 INFO anaconda: Created mdmember on /dev/sda1
>>>   19:58:42,499 INFO anaconda: Creating lvmpv on /dev/md/2
>>>   19:59:45,248 INFO anaconda: Created lvmpv on /dev/md/2
>>>   20:00:44,268 INFO anaconda: Creating ext4 on /dev/mapper/vg00-mgtservices
>>>   20:01:15,815 INFO anaconda: Created ext4 on /dev/mapper/vg00-mgtservices
>>>   20:01:31,088 INFO anaconda: Creating ext4 on /dev/mapper/vg00-home
>>>   20:02:02,074 INFO anaconda: Created ext4 on /dev/mapper/vg00-home
>>>   20:02:27,638 INFO anaconda: Creating ext4 on /dev/mapper/vg00-var
>>>   20:03:04,709 INFO anaconda: Created ext4 on /dev/mapper/vg00-var
>>>   20:03:33,545 INFO anaconda: Creating ext4 on /dev/mapper/vg00-opt
>>>   20:04:17,431 INFO anaconda: Created ext4 on /dev/mapper/vg00-opt
>>>   20:04:47,419 INFO anaconda: Creating ext4 on /dev/mapper/vg00-tmp
>>>   20:05:29,563 INFO anaconda: Created ext4 on /dev/mapper/vg00-tmp
>>>   20:06:05,318 INFO anaconda: Creating ext4 on /dev/mapper/vg00-usr
>>>   20:06:51,398 INFO anaconda: Created ext4 on /dev/mapper/vg00-usr
>>>   20:07:25,466 INFO anaconda: Creating ext4 on /dev/mapper/vg00-log
>>>   20:08:10,052 INFO anaconda: Created ext4 on /dev/mapper/vg00-log
>>>   20:15:02,513 INFO anaconda: Creating mdmember on /dev/sda2
>>>   20:15:32,119 INFO anaconda: Created mdmember on /dev/sda2
>>>   20:15:57,297 INFO anaconda: Creating ext4 on /dev/md/1
>>>   20:16:37,913 INFO anaconda: Created ext4 on /dev/md/1
>>>   20:22:51,738 INFO anaconda: Creating mdmember on /dev/sda5
>>>   20:22:51,826 INFO anaconda: Created mdmember on /dev/sda5
>>>   20:22:55,472 INFO anaconda: Creating ext4 on /dev/md/0
>>>   20:22:56,837 INFO anaconda: Created ext4 on /dev/md/0
>>>   20:22:56,859 INFO anaconda: Creating mdmember on /dev/sda3
>>>   20:22:57,151 INFO anaconda: Created mdmember on /dev/sda3
>>>   20:23:04,052 INFO anaconda: Creating swap on /dev/md/3
>>>   20:23:30,488 INFO anaconda: Created swap on /dev/md/3
>>>
>>> You can see the whole process takes over 20 minutes.  Now the results
>>> after the patch revert, snipped for brevity.
>>>
>>>   16:45:17,990 INFO anaconda: Creating disklabel on /dev/sdb
>>>   16:45:18,040 INFO anaconda: Created disklabel on /dev/sdb
>>>   .....snip
>>>   16:45:36,837 INFO anaconda: Creating swap on /dev/md/3
>>>   16:45:36,935 INFO anaconda: Created swap on /dev/md/3
>>>
>>> Way down to 20 seconds... pretty severe impact.  And as mentioned
>>> prior, the issue/impact extends on into package installation, app
>>> installation and standard app load.
>>> Is there a fix here that you guys can see?  Or is this enough to
>>> decide on rolling back that patch?
>>> Please let me know if I can be of help.
>>>
>>
>> Hi John
>>
>> I found Shaohua gave a patch to resolve this problem at this topic
>> https://www.spinics.net/lists/raid/msg51395.html. But there is no test
>> result. Could you try it?
>>
>> Best Regards
>> Xiao
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux