Re: [PATCH 1/2] mdadm/manpage:update description for readonly in manpage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/10/2017 04:04 AM, Zhilong Liu wrote:
update readonly/readwrite in man page:
Currently both the readwrite and readonly are worked well,
thus updates description for them.

Signed-off-by: Zhilong Liu <zlliu@xxxxxxxx>
---
 mdadm.8.in | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

A couple of comments below.

 .TP
 .B \-\-readonly
-start the array readonly \(em not supported yet.
+start the array with readonly status.

I believe it would be more correct to say "start the array in readonly mode" here.

 .SH MANAGE MODE
 .HP 12
@@ -2438,12 +2439,11 @@ This will fully activate a partially assembled md array.

 .TP
 .B \-\-readonly
-This will mark an active array as read-only, providing that it is
-not currently being used.
+This will set an active array as read-only status.

I think this chance is not good, and should be omitted.

 .TP
 .B \-\-readwrite
-This will change a
+This will change an
 .B readonly
 array back to being read/write.

This change is grammatically incorrect I believe and the original text is correct.

Thanks,
Jes

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux