On Mon, Mar 27 2017, Christoph Hellwig wrote: > I don't really like the flag at all. I'd much prefer a __bio_endio > with a 'bool trace' flag. Also please remove the manual tracing in > dm.ċ. Once that is done I suspect we can also remove the > block_bio_complete export. Can you say why you don't like it? I find that it neatly handles all the corner cases that I found, and keeps the complexity local. Were we to use a flag to __bio_endio(), we would need one to __generic_make_request() too because we really don't want 'QUEUE' tracing when when blk_queue_split() (and similar code) calls it. Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
