Re: [PATCH v3] block: trace completion of all bios.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: NeilBrown <neilb@xxxxxxxx>
Subject: Re: [PATCH v3] block: trace completion of all bios.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 27 Mar 2017 02:03:08 -0700
Cc: Ming Lei <tom.leiming@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Shaohua Li <shli@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>
In-reply-to: <87fui3a65o.fsf@notabene.neil.brown.name>
References: <877f3iave6.fsf@notabene.neil.brown.name> <20170322125149.GA29606@infradead.org> <87shm4a4lt.fsf@notabene.neil.brown.name> <20170323104331.GA16903@ming.t460p> <87fui3a65o.fsf@notabene.neil.brown.name>
User-agent: Mutt/1.7.1 (2016-10-04)

I don't really like the flag at all.  I'd much prefer a __bio_endio
with a 'bool trace' flag.  Also please remove the manual tracing in
dm.ċ.  Once that is done I suspect we can also remove the
block_bio_complete export.
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [PATCH v3] block: trace completion of all bios.
  - From: NeilBrown

References:
- [PATCH] block: trace completion of all bios.
  - From: NeilBrown
- Re: [PATCH] block: trace completion of all bios.
  - From: Christoph Hellwig
- [PATCH v2] block: trace completion of all bios.
  - From: NeilBrown
- Re: [PATCH v2] block: trace completion of all bios.
  - From: Ming Lei
- [PATCH v3] block: trace completion of all bios.
  - From: NeilBrown

Prev by Date: Re: [mdadm PATCH 4/5] Add 'force' flag to *hot_remove_disk().
Next by Date: Re: RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload
Previous by thread: Re: [PATCH v3] block: trace completion of all bios.
Next by thread: Re: [PATCH v3] block: trace completion of all bios.
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]