> On Mar 15, 2017, at 3:51 PM, Shaohua Li <shli@xxxxxxxxxx> wrote: > > On Wed, Mar 15, 2017 at 11:28:15AM -0700, Song Liu wrote: >> 1. suspend the array before adding journal, so that we can add journal >> when the array is not read-only; > > we can't call mddev_suspend in raid5d, because there is deadlock. > raid5_add_disk can be called in raid5d. I see. I guess we can just require setting read only before adding journal. > >> 2. allow recreate journal when existing journal is Faulty. So that we can >> add-journal before removing failed journal. > > this is weird usage, why don't we remove the failed journal first? This is really not necessary. I guess we can just drop this patch. Thanks, Song -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
