> On Mar 14, 2017, at 10:50 AM, Shaohua Li <shli@xxxxxxxxxx> wrote: > > On Mon, Mar 13, 2017 at 04:36:26PM -0700, Song Liu wrote: >> For the raid456 with writeback cache, when journal device failed during >> normal operation, it is still possible to persist all data, as all >> pending data is still in stripe cache. However, the stripe will be >> marked as fail with s.log_failed. Thus, the write out from stripe cache >> cannot make progress. >> >> To unblock the write out in journal failures, this patch allows stripes >> with data injournal to make progress. > > what about the parity part? if log failed, we should skip journaling the parity. > Hmm.. I guess we need to check Faulty bit in some functions. Simply checking log is not NULL is not enough. I will update the patch. Thanks, Song-- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html