On Wed, Sep 07, 2016 at 05:43:35PM -0700, Song Liu wrote: > struct mdp_superblock_1.set_name is 32B long, but struct mdinfo.name > is 33B long. So we need strncpy instead strcpy to avoid buffer > overflow. > > Signed-off-by: Song Liu <songliubraving@xxxxxx> > --- > super1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/super1.c b/super1.c > index f3e4023..46fed54 100644 > --- a/super1.c > +++ b/super1.c > @@ -1294,7 +1294,7 @@ static int update_super1(struct supertype *st, struct mdinfo *info, > strcat(sb->set_name, ":"); > strcat(sb->set_name, info->name); > } else > - strcpy(sb->set_name, info->name); > + strncpy(sb->set_name, info->name, 32); strncpy(sb->set_name, info->name, sizeof(sb->set_name)); ? -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
