On Wed, Jul 29, 2015 at 05:38:42PM -0700, Shaohua Li wrote: > Cache device stores data in a log structure. We need record the log > start. Here we override md superblock recovery_offset for this purpose. > This field of a cache device is meaningless otherwise. Just reusing the field for a different purpose without a different name or comment is highly confusing. I'd suggest to create unions in both the on-disk and in-memory structures and properly document that new usage for cache devices. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html