When parse_cluster_confirm_arg return 0, it means the arg are parsed successfully, so change !rv to rv. Signed-off-by: Guoqing Jiang <gqjiang@xxxxxxxx> --- Against cluster branch, it could be squashed with commit 4de9091 "Add a new clustered disk", sorry for inconvenience. Manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Manage.c b/Manage.c index e3bdfb3..377df32 100644 --- a/Manage.c +++ b/Manage.c @@ -1302,7 +1302,7 @@ int Manage_subdevs(char *devname, int fd, rv = parse_cluster_confirm_arg(dv->devname, &dv->devname, &raid_slot); - if (!rv) { + if (rv) { pr_err("Could not get the devname of cluster\n"); goto abort; } -- 1.7.12.4 -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html