Am Donnerstag, den 24.11.2011, 12:28 +0000 schrieb Kwolek, Adam: > > -----Original Message----- > > From: Paul Menzel [mailto:pm.debian@xxxxxxxxxxxxxx] > > Sent: Thursday, November 24, 2011 1:23 PM > > To: Kwolek, Adam > > Cc: neilb@xxxxxxx; linux-raid@xxxxxxxxxxxxxxx; Ciechanowski, Ed; Labun, > > Marcin; Williams, Dan J > > Subject: Re: [PATCH] md: Add ability for disable bad block management > > > > Dear Adam, > > > > > > Am Donnerstag, den 24.11.2011, 13:19 +0100 schrieb Adam Kwolek: > > > When external metadata doesn't support BBM, mdadm cannot answer > > > correctly for BBM requests. It causes reshape process being stopped. > > > > > > Add ability for external metadata /mdadm/ to disable BBM via sysfs. > > > md will ignore bad blocks as it is for metadata v0.90. > > > > > > Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx> > > > --- > > > > > > drivers/md/md.c | 11 ++++++++++- > > > 1 files changed, 10 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/md/md.c b/drivers/md/md.c index 266e82e..6591108 > > > 100644 > > > --- a/drivers/md/md.c > > > +++ b/drivers/md/md.c > > > @@ -2935,7 +2935,16 @@ static ssize_t bb_show(struct md_rdev *rdev, > > > char *page) } static ssize_t bb_store(struct md_rdev *rdev, const > > > char *page, size_t len) { > > > - int rv = badblocks_store(&rdev->badblocks, page, len, 0); > > > + int rv; > > > + > > > + /* disable bad blocks managment > > > > manag*e*ment > > > > > + */ > > > + if (strstr(page, "disable") == page) { > > > + bb->shift = -1; > > > + return len; > > > + } > > > + > > > + rv = badblocks_store(&rdev->badblocks, page, len, 0); > > > /* Maybe that ack was all we needed */ > > > if (test_and_clear_bit(BlockedBadBlocks, &rdev->flags)) > > > wake_up(&rdev->blocked_wait); > > > > Also this seems to collide with PATCH 11/11, does not it? > In my opinion it doesn't. > Patch 11/11 in mdadm allows for disabling BBM per rdev by setting 'disable' word in sysfs. > This patch interprets in md this action and disables BBM (per rdev also) . > > Do you agree? Yes. Thank you for your explanation. I just saw the same typo. So please correct that typo in 11/11 also. Thanks, Paul
Attachment:
signature.asc
Description: This is a digitally signed message part
