Re: [PATCH] GCC compile fix: remove calculation of unused variable 'reservation'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 27 Oct 2011 07:46:10 +0000 "Czarnowska, Anna"
<anna.czarnowska@xxxxxxxxx> wrote:

> I have sent a patch removing the unused variable a while ago.
> It must have been overlooked.

OK, thanks.

(And sorry I missed the patch)

NeilBrown


> Regards
> Anna
> 
> > -----Original Message-----
> > From: linux-raid-owner@xxxxxxxxxxxxxxx [mailto:linux-raid-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of NeilBrown
> > Sent: Thursday, October 27, 2011 6:33 AM
> > To: Jes Sorensen
> > Cc: linux-raid@xxxxxxxxxxxxxxx; Czarnowska, Anna
> > Subject: Re: [PATCH] GCC compile fix: remove calculation of unused
> > variable 'reservation'
> > 
> > On Wed, 26 Oct 2011 14:51:36 +0200 Jes Sorensen
> > <Jes.Sorensen@xxxxxxxxxx>
> > wrote:
> > 
> > > On 10/06/11 16:43, Jes.Sorensen@xxxxxxxxxx wrote:
> > > > From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> > > >
> > > > gcc 4.6.1 doesn't like calculating a variable that then isn't
> > > > used. Remove it.
> > > >
> > > > Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> > > > ---
> > > >  super-intel.c |    2 --
> > > >  1 files changed, 0 insertions(+), 2 deletions(-)
> > >
> > > Neil,
> > >
> > > Any chance you could reply this one? It still seems to be an issue
> > with
> > > the latest git tree.
> > >
> > > Thanks,
> > > Jes
> > 
> > Yeah - sorry. I wanted to check that it really should be removed and
> > there
> > wasn't some other bug hiding - but I looks like it is simply
> > unnecessary.
> > Hopefully Anna will correct me if I'm wrong...
> > 
> > I''ve applied your patch.
> > 
> > Thanks,
> > NeilBrown
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux