On Wed, 09 Mar 2011 14:46:10 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote:
> When reshape continuation fails, reshaped array should remain frozen
> to allow user for repair action (mdmon will not change array state).
> Setting restart to 0 was moved down to allow failure detection.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> ---
>
> Grow.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index e37fc57..67bbb26 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2255,11 +2255,12 @@ int reshape_container(char *container, char *devname,
> content, force,
> backup_file, quiet, 1, restart);
> close(fd);
> - restart = 0;
> if (rv)
> break;
> + restart = 0;
> }
> - unfreeze(st);
> + if (restart == 0)
> + unfreeze(st);
> sysfs_free(cc);
> exit(0);
> }
>
Not applied... it is probably close to right, but I'm a little confused.
Surely we should never never unfreeze on an error - not only in the restart
case...
And the code doesn't make it obvious that the unfreeze is only in the
error case...
Maybe
if (!rv)
unfreeze(st);
??
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
