On Tue, 01 Mar 2011 15:57:06 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote:
> Some raid_disks that are used for expansion, are not configured yet.
> This is due to earlier set raid_disks limitation.
> Set raid_disks to new (bigger) value and finish disks slot configuration.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> ---
>
> Assemble.c | 15 ++++++++++++++-
> 1 files changed, 14 insertions(+), 1 deletions(-)
>
> diff --git a/Assemble.c b/Assemble.c
> index 6aff049..fa3a0a6 100644
> --- a/Assemble.c
> +++ b/Assemble.c
> @@ -1586,9 +1586,22 @@ int assemble_container_content(struct supertype *st, int mdfd,
> chosen_name, working + preexist);
> if (preexist)
> fprintf(stderr, " (%d new)", working);
> - if (expansion)
> + if (expansion) {
> fprintf(stderr, " ( + %d for expansion)",
> expansion);
> + sysfs_set_num(content, NULL, "raid_disks",
> + content->array.raid_disks + expansion);
> + for (dev = content->devs; dev; dev = dev->next)
> + if (dev->disk.raid_disk >=
> + content->array.raid_disks) {
> + int rv;
> + dprintf("\n\tExpansion: configure slot:"
> + "%i", dev->disk.raid_disk);
> + rv = sysfs_set_num(content, dev, "slot",
> + dev->disk.raid_disk);
> + dprintf(" (status = %i)\n", rv);
> + }
> + }
> fprintf(stderr, "\n");
> }
> if (!err)
I thought I explained how this was suppose to work....
1/ Set the 'old' geometry of the array. sysfs_set_array does this.
2/ Set 'reshape_position'. sysfs_set_array does this.
3/ Set the 'new' geometry of the array. sysfs_set_array should do this but
it doesn't.
4/ Add all the disks. Repeated calls to sysfs_add_disk will do this.
5/ start the array readonly . assemble_container_content calls sysfs_set_str
to do this.
That is all.
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
