[PATCH] imsm: FIX: not all disks are released in free_imsm_disks()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adding spare disks to imsm container fails due to problem with writing
new_dev to sysfs. This problem was caused by not closed handle
(opened exclusively) in Manage.c:803.

Disk handle was not closed by free_imsm().
This is due to not released disk_mgmt_list in free_imsm_disks().

Proper release of imsm metadata allows for spare adding without problems.
Memory leak was fixed also.

Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
---

 super-intel.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 958a02b..8bb21dd 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -2687,6 +2687,11 @@ static void free_imsm_disks(struct intel_super *super)
 		super->disks = d->next;
 		__free_imsm_disk(d);
 	}
+	while (super->disk_mgmt_list) {
+		d = super->disk_mgmt_list;
+		super->disk_mgmt_list = d->next;
+		__free_imsm_disk(d);
+	}
 	while (super->missing) {
 		d = super->missing;
 		super->missing = d->next;

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux