> -----Original Message----- > From: Neil Brown [mailto:neilb@xxxxxxx] > Sent: Thursday, January 27, 2011 4:07 AM > To: Kwolek, Adam > Cc: linux-raid@xxxxxxxxxxxxxxx; Williams, Dan J; Ciechanowski, Ed; > Neubauer, Wojciech > Subject: Re: [PATCH] FIX: reshape_active flag is always set for > external metadata > > On Thu, 20 Jan 2011 16:52:31 +0100 > Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote: > > > For external metadata based on reshape_active flag is taken decision > > about reshape when it is equal to 1. At this momenta mdadm cannot > > give up when this flag is set for external metadata. > > > > Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx> > > --- > > > > Grow.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/Grow.c b/Grow.c > > index c9f4b9c..f220f50 100644 > > --- a/Grow.c > > +++ b/Grow.c > > @@ -1870,7 +1870,7 @@ started: > > > > sra->new_chunk = info->new_chunk; > > > > - if (info->reshape_active) > > + if ((info->reshape_active) && (st->ss->external == 0)) > > This is a bit too simplistic. I have applied a patch which is > (hopefully) more thorough. > > Thanks, > NeilBrown Your patch is OK. Thanks Adam > > > /* nothing needed here */; > > else if (info->array.chunk_size == info->new_chunk && > > reshape.before.layout == reshape.after.layout && > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-raid" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
