[PATCH 1/2] md/raid5: FIX: manually-added spare is not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Manually added spares are not used due to fact that they not added to md configuration.
Counters are updated only.

Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
---

 drivers/md/raid5.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index a2087c7..59c4150 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -5592,8 +5592,10 @@ static int raid5_start_reshape(mddev_t *mddev)
 		} else if (rdev->raid_disk >= conf->previous_raid_disks
 			   && !test_bit(Faulty, &rdev->flags)) {
 			/* This is a spare that was manually added */
-			set_bit(In_sync, &rdev->flags);
-			added_devices++;
+			if (raid5_add_disk(mddev, rdev) == 0) {
+				set_bit(In_sync, &rdev->flags);
+				added_devices++;
+			}
 		}
 
 	/* When a reshape changes the number of devices, ->degraded

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux