> -----Original Message----- > From: NeilBrown [mailto:neilb@xxxxxxx] > Sent: Thursday, January 13, 2011 3:52 AM > To: Wojcik, Krzysztof > Cc: linux-raid@xxxxxxxxxxxxxxx; Neubauer, Wojciech; Kwolek, Adam; > Williams, Dan J; Ciechanowski, Ed > Subject: Re: [PATCH 5/6] Remove code for non re-striping operations. > > On Wed, 12 Jan 2011 17:01:32 +0100 Krzysztof Wojcik > <krzysztof.wojcik@xxxxxxxxx> wrote: > > > Neil, > > How was your intention when you add this part of code? > > I can't find the case when it will be necessary. > > Moreover it breaks flow for takeover operations because > > ioctl not succeeded when more than one parameter is changed. > > I've remove this code temporally to be able test takeover > > operations. > > We can restore this code after we decide what it should do. > > Asking what the purpose of some code is is perfectly OK. Asking by > sending a > patch which removes the code seems ... odd. Sorry. It was just a proposal :) > > If the number of data devices is 1, then a RAID5 can have > layout/chunksize > changed without any restriping. > This code handles that case. So maybe it will be good to limit this part of code execution only for raid5? (reshape.backup_blocks == 0) { If (info->array.level != 5) Return rv; ... How do you mean? > > NeilBrown > > > > > > Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@xxxxxxxxx> > > --- > > Grow.c | 43 +++++-------------------------------------- > > 1 files changed, 5 insertions(+), 38 deletions(-) > > > > diff --git a/Grow.c b/Grow.c > > index 253f289..6835f34 100644 > > --- a/Grow.c > > +++ b/Grow.c > > @@ -1666,6 +1666,11 @@ static int reshape_array(char *container, int > fd, char *devname, > > ping_monitor(container); > > } > > > > + if (reshape.backup_blocks == 0) { > > + /* If operation not not reuire re-striping we can finish */ > > + return rv; > > + } > > + > > /* ->reshape_super might have chosen some spares from the > > * container that it wants to be part of the new array. > > * We can collect them with ->container_content and give > > @@ -1692,44 +1697,6 @@ static int reshape_array(char *container, int > fd, char *devname, > > } > > } > > > > - if (reshape.backup_blocks == 0) { > > - /* No restriping needed, but we might need to impose > > - * some more changes: layout, raid_disks, chunk_size > > - */ > > - if (info->new_layout != UnSet && > > - info->new_layout != info->array.layout) { > > - info->array.layout = info->new_layout; > > - if (ioctl(fd, SET_ARRAY_INFO, &info->array) != 0) { > > - fprintf(stderr, Name ": failed to set new > layout\n"); > > - rv = 1; > > - } else if (!quiet) > > - printf("layout for %s set to %d\n", > > - devname, info->array.layout); > > - } > > - if (info->delta_disks != UnSet && > > - info->delta_disks != 0) { > > - info->array.raid_disks += info->delta_disks; > > - if (ioctl(fd, SET_ARRAY_INFO, &info->array) != 0) { > > - fprintf(stderr, Name ": failed to set raid > disks\n"); > > - rv = 1; > > - } else if (!quiet) > > - printf("raid_disks for %s set to %d\n", > > - devname, info->array.raid_disks); > > - } > > - if (info->new_chunk != 0 && > > - info->new_chunk != info->array.chunk_size) { > > - if (sysfs_set_num(info, NULL, > > - "chunk_size", info->new_chunk) != 0) { > > - fprintf(stderr, Name ": failed to set chunk > size\n"); > > - rv = 1; > > - } else if (!quiet) > > - printf("chunk size for %s set to %d\n", > > - devname, info->array.chunk_size); > > - } > > - > > - return rv; > > - } > > - > > /* > > * There are three possibilities. > > * 1/ The array will shrink. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
