Re: [PATCH 7/8] Finalize reshape after adding disks to array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Jan 2011 14:55:18 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote:

> When reshape is finished, monitor has to finalize reshape in metadata for curent array.
> To do this set_array_state() should be called.
> This finishes migration and stores metadata on disks.
> 
> This finishes reshape flow in mdmon.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> ---
> 
>  monitor.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index 1107d47..a0068d3 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -322,6 +322,17 @@ static int read_and_act(struct active_array *a)
>  		 */
>  		check_reshape = 1;
>  
> +	/* finalize reshape detection
> +	 */
> +	if ((a->curr_action != reshape) &&
> +	    (a->prev_action == reshape)) {
> +		/* A reshape has finished.
> +		 * Some disks may be in sync now.
> +		 */
> +		a->container->ss->set_array_state(a, a->curr_state <= clean);
> +		check_degraded = 1;
> +	}
> +
>  	/* Check for failures and if found:
>  	 * 1/ Record the failure in the metadata and unblock the device.
>  	 *    FIXME update the kernel to stop notifying on failed drives when
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


One day you will explain to me why the current code isn't sufficient like I
keep asking you do.  Then maybe I'll apply this patch.

Until then, I won't.

NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux