Re: [PATCH 5/8] FIX: Cannot load container information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Jan 2011 14:55:03 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote:

> When container is passed to grow_reshape(), load_container() function has to be used to
> get all required information from metadata. In such case subarray variable is not set.
> This means that currently used condition is wrong.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> ---
> 
>  Grow.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Grow.c b/Grow.c
> index c2e84f3..519fbc2 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1356,7 +1356,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
>  		fmt_devname(container_buf, container_dev);
>  		container = container_buf;
>  
> -		if (subarray)
> +		if (!subarray)
>  			rv = st->ss->load_container(st, cfd, NULL);
>  		else
>  			rv = st->ss->load_super(st, cfd, NULL);

load_super is never correct here, so I change this to always call
load_container.

Thanks,
NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux