Re: [PATCH 3/8] imsm: FIX: local mdadm update shouldn't be done in update creation function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Jan 2011 14:54:42 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote:

> Local update is performed based on created update, so this code can broke
> local update and it is not necessary as prepare and process update functions
> are used.
> 
> Code removed.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> ---
> 
>  super-intel.c |   13 -------------
>  1 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/super-intel.c b/super-intel.c
> index 7038433..de41702 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -6492,19 +6492,6 @@ static int imsm_create_metadata_update_for_reshape(
>  		mpb->num_disks++;
>  		dev = dev->next;
>  	}
> -	/* Now update the metadata so that container_content will find
> -	 * the new devices
> -	 */
> -	for (i = 0; i < mpb->num_raid_devs; i++) {
> -		int d;
> -		struct imsm_dev *dev = get_imsm_dev(super, i);
> -		struct imsm_map *map = get_imsm_map(dev, 0);
> -		map->num_members = geo->raid_disks;
> -		for (d = 0; d < delta_disks; d++) {
> -			set_imsm_ord_tbl_ent(map, old_raid_disks + d,
> -					     mpb->num_disks - delta_disks + d);
> -		}
> -	}
>  
>  abort:
>  	/* free spares

Applied, thanks.

NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux