RE: [PATCH 10/13] FIX: Cannot unmount array after reshape

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: NeilBrown [mailto:neilb@xxxxxxx]
> Sent: Wednesday, January 12, 2011 5:53 AM
> To: Kwolek, Adam
> Cc: linux-raid@xxxxxxxxxxxxxxx; Williams, Dan J; Ciechanowski, Ed;
> Neubauer, Wojciech
> Subject: Re: [PATCH 10/13] FIX: Cannot unmount array after reshape
> 
> On Mon, 10 Jan 2011 12:28:48 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx>
> wrote:
> 
> > After reshape array remains blocked (i.e. cannot be umounted) due to
> suspend_lo
> > sysfs entry setting.
> >
> > Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> 
> I think I have address this issues elsewhere in the code.
> 
> Thanks,
> NeilBrown

I agree, it is addressed now.

Thanks 
Adam

> 
> > ---
> >
> >  Grow.c |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/Grow.c b/Grow.c
> > index 6b2889e..f083ba5 100644
> > --- a/Grow.c
> > +++ b/Grow.c
> > @@ -2026,6 +2026,7 @@ static int reshape_array(char *container, int
> fd, char *devname,
> >  				unsigned long long current_size = 0;
> >  				unsigned long long new_size =
> >  					info2->custom_array_size/2;
> > +				unsigned long long suspend_value;
> >
> >  				if (sysfs_get_ll(sra,
> >  						 NULL,
> > @@ -2043,6 +2044,13 @@ static int reshape_array(char *container, int
> fd, char *devname,
> >  					dprintf(" from %llu to %llu.\n",
> >  						current_size, new_size);
> >  				}
> > +				/* manage suspend_* entries
> > +				 * set suspend_lo to suspend_hi value
> > +				 * to unblock array
> > +				 */
> > +				sysfs_get_ll(sra, NULL, "suspend_hi",
> &suspend_value);
> > +				sysfs_set_num(sra, NULL, "suspend_lo",
> suspend_value);
> > +
> >  				sysfs_free(info2);
> >  			}
> >  		}

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux