[PATCH 2/5] Added test for array degradation for spare-same-slot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



spare-same-slot allows re-adding of missing array member with disk
re-inserted into the same slot where previous member was plugged in.
If in the meantime another spare has been used for recovery, same slot
cookie should be ignored.

Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@xxxxxxxxx>
---
 Incremental.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Incremental.c b/Incremental.c
index ef719fa..137bd75 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -968,11 +968,13 @@ static int array_try_spare(char *devname, int *dfdp, struct dev_policy *pol,
 		 * arrays/containers that match 'target'.
 		 * If 'target' is set and 'bare' is true, we prefer the
 		 * array which matches 'target'.
+		 * target is considered only if we deal with degraded array
 		 */
 		if (target) {
 			if (strcmp(target->metadata, mp->metadata) == 0 &&
 			    memcmp(target->uuid, mp->uuid,
-				   sizeof(target->uuid)) == 0) {
+				   sizeof(target->uuid)) == 0 && 
+			    sra->array.failed_disks > 0) {
 				/* This is our target!! */
 				if (chosen)
 					sysfs_free(chosen);

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux