> I don't think it is possible to come up with an automatic way to > determine if > a given spare suits a given array that is always correct. There are > too many > subtleties. > So I would like to allow the sysadmin to exercise complete control, and > have > defaults that make reasonable sense in common cases. > > The 'complete control' can be exercised through domain - though I will > probably add some size based rule mechanism to the policy code so > devices can > be categorised by size if wanted. > The 'safe default' is probably best left to the metadata handler. So > ultimately all metadata types *should* specify > min_acceptable_spare_size, > and we will just make do with that. > > Does that sound OK? Yes. When all metadata types have min_acceptable_spare_size there will be no need for min_active_disk_size at all. One more thought: Manage_subdevs checks component_size so for native metadata it will not allow to add a spare that is too small. But checking size in Monitor will prevent unnecessary removal and re-adding. It would make sense to get Manage_subdevs to check the size properly for external metadata too. Anna --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882 NIP 957-07-52-316 Kapital zakladowy 200.000 zl This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html