On Mon, 22 Nov 2010 16:11:41 -0800 Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > On 11/22/2010 3:50 PM, Hawrylewicz Czarnowski, Przemyslaw wrote: > >> Four comments. > >> > >> 1/ I wouldn't write a file in /lib/udev/rules.d/ > >> I think it should be written to "/dev/.udev/rules.d/" > >> which is referred to as the "temporary rules directory" > >> in the udev documentation. > > I am not sure if it is what we are looking for. Temporary means they disappear after reboot. It is OK as cold-plug does not need support for bare disks (or maybe I am wrong?). But in such case, one who wants to use autorebuild should invoke mdadm --activate-domains for example in /etc/init.d/local.boot or somewhere else. Second idea here is to use ActivateDomain() when one starts monitor with autorebuild enabled. Which one? I would prefer to leave it as it was written initially (considering comment #4). Then, if one removes policies from config, invoking --activate-domains should reset/remove rules (but see #3) > > The intent was always to have this be something reinitialized at boot. > Putting these in the temporary rule directory also precludes them from > being added to the initramfs where they are not needed / potentially > confusing. > > The other intent was to only match the pci paths for the controllers we > cared about. That does not appear to be a part of this patch. Can you define "we cared about". Don't we care about everything listed in mdadm.conf?? > > > > >> > >> 2/ I would be good to process the type=disk or type=part part of the > >> policy into the rules file as well. > > OK > > > >> > >> 3/ I'm not very comfortable with hard-coding the name of the > >> file to be created in the rules.d directory. Maybe usage could be > >> --activate-domains=63-md-whatever > > Good idea, but only if we store our rules in /dev/.udev/rules.d. Otherwise it would be difficult to maintain all generated rules and remove the old ones... I would leave default if not given by user, but one can pass any file name. > > The issue is that this namespace belongs to the distro and since they > need to modify initscripts to turn this feature on might as well dump > the entirety of the naming responsibility to the user. > > >> 4/ I don't think it is good to have an incomplete file in rules.d that udev > >> might accidentally read. We should create the file with a name with a > >> leading '.' (assuming udev ignores those, I haven't checked) and then > >> rename it after it has been completely written. > > You're right. In theory, such partial udev rules are excluded when udev can't interpret them properly. I have looked into udev's sources and found that it looks for "*.rules" files. All other file extensions are ignored. Files with leading dots are also omitted. I would prefer to create<name>.temp file and then rename it into<name>.rules. > > There must be an existing convention for this sort of the thing, if so > let's not invent another one. We could avoid both these issues by just writing the new rules file to stdout. When when the init script gets it wrong, it isn't our fault :-) But I don't really like that. At least there should be a simple and uniform way to propagate any mdadm.conf changes into udev. Maybe the name of the rules file should be given in mdadm.conf, and e.g. mdadm --check-config would report any syntax errors, report any inconsistencies with current arrays, and update the udev file if necessary.. Maybe leave that for 3.2.1, and just support '--activate-domains=filename' for now. ??? NeilBrown > > -- > Dan > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
