On Thu, Nov 11, 2010 at 12:51 PM, Mathias Burén <mathias.buren@xxxxxxxxx> wrote:
> On 11 November 2010 20:25, Justin Maggard <jmaggard10@xxxxxxxxx> wrote:
>> When trying to grow an array by enlarging component devices, rdev_size_store()
>> expects the return value of rdev_size_change() to be in sectors, but the actual
>> value is returned in KBs.
>>
>> Signed-off-by: Justin Maggard <jmaggard10@xxxxxxxxx>
>> ---
>> drivers/md/md.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>> index 4e957f3..a0615af 100644
>> --- a/drivers/md/md.c
>> +++ b/drivers/md/md.c
>> @@ -1337,7 +1337,7 @@ super_90_rdev_size_change(mdk_rdev_t *rdev, sector_t num_sectors)
>> md_super_write(rdev->mddev, rdev, rdev->sb_start, rdev->sb_size,
>> rdev->sb_page);
>> md_super_wait(rdev->mddev);
>> - return num_sectors / 2; /* kB for sysfs */
>> + return num_sectors;
>> }
>>
>>
>> @@ -1704,7 +1704,7 @@ super_1_rdev_size_change(mdk_rdev_t *rdev, sector_t num_sectors)
>> md_super_write(rdev->mddev, rdev, rdev->sb_start, rdev->sb_size,
>> rdev->sb_page);
>> md_super_wait(rdev->mddev);
>> - return num_sectors / 2; /* kB for sysfs */
>> + return num_sectors;
>> }
>>
>> static struct super_type super_types[] = {
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> Hi,
>
> What is the effect of this bug?
>
> // Mathias
>
mdadm -G fails with enlarged component devices.
-Justin
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
