On Sat, 27 Feb 2010 11:14:43 +0100 Luca Berra <bluca@xxxxxxxxxx> wrote: > building current git with -O2 -Wall -Werror aborts with compiler warnings > patch 1 fixes a strict-aliasing violation > patch 2 addresses trivial to fix warning > patch 3 is just _WRONG_: there is no clear way to bailout from the functions in > Grow.c, and i have no idea if aborting would leave the array in an inconsistent > state. For the time being I just decided to please gcc by storing the result > somwere, but it is never checked. Thanks. I needed to add -D_FORTIFY_SOURCE=2 to get all those warnings as well, so I've told the Makefile about that. Your patches were space-damaged somehow so I didn't apply them directly, but I have fixed up all the warnings, sometimes the same way that you did, soemthings differently. Thanks. NeilBrown > > L. > > Luca Berra (3): > fix gcc warnings about strict-aliasing rules > fix compiler warnings > workaround unused_results > > Grow.c | 30 +++++++++++++++++++----------- > mdmon.c | 2 +- > restripe.c | 2 +- > util.c | 4 ++-- > 4 files changed, 23 insertions(+), 15 deletions(-) > > -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
