Re: [mdadm PATCH] Move symbol definitions from source files to Makefile.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 Jan 2010 16:05:58 +0100
Artur Wojcik <artur.wojcik@xxxxxxxxx> wrote:

> On Fri, 2010-01-29 at 09:45 +0000, Neil Brown wrote:
> > On Thu, 28 Jan 2010 16:47:45 +0100
> > Artur Wojcik <artur.wojcik@xxxxxxxxx> wrote:
> > 
> > > This patch will move _GNU_SOURCE and _FILE_OFFSET_BITS=64 from
> > > various source files to Makefile.
> > 
> > Why?
> > 
> 
> The reason is to clean up the code. The new files will appear soon and I
> want this two definitions to be set globally instead of per source file.

Personally, I prefer them to be set just where they are needed.  You could
possibly convince me to put them in mdadm.h, but not in Makefile.

> 
> There's the plan to use GNU autotools to simply the build process, too.

That plan should be dropped immediately.  It won't happen.

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux