RE: [PATCH v2 02/11] async_tx: kill ASYNC_TX_DEP_ACK flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Williams wrote:
> In support of inter-channel chaining async_tx utilizes an ack flag to
> gate whether a dependent operation can be chained to another.  While the
> flag is not set the chain can be considered open for appending.  Setting
> the ack flag closes the chain and flags the descriptor for garbage
> collection.  The ASYNC_TX_DEP_ACK flag essentially means "close the
> chain after adding this dependency".  Since each operation can only have
> one child the api now implicitly sets the ack flag at dependency
> submission time.  This removes an unnecessary management burden from
> clients of the api.
> 
> [ Impact: clean up and enforce one dependency per operation ]
> 
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  crypto/async_tx/async_memcpy.c |    2 +-
>  crypto/async_tx/async_memset.c |    2 +-
>  crypto/async_tx/async_tx.c     |    4 ++--
>  crypto/async_tx/async_xor.c    |    6 ++----
>  drivers/md/raid5.c             |   25 +++++++++++--------------
>  include/linux/async_tx.h       |    4 +---
>  6 files changed, 18 insertions(+), 25 deletions(-)

Async-tx-api.txt documentation should be also updated
(it still describes ASYNC_TX_DEP_ACK usage).

Acked-by: Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux