On Tuesday May 19, raziebe@xxxxxxxxx wrote:
> have raid1 check chunk size in run method instead of in md
I dropped this patch. chunk_size is not meaningful for raid1.
NeilBrown
> raid1.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
> Signed-off-by: raziebe@xxxxxxxxx
> ---
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 2c8d9e6..8609506 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1942,6 +1942,15 @@ static int run(mddev_t *mddev)
> mdname(mddev), mddev->level);
> goto out;
> }
> + /*
> + * chunk-size has to be a power of 2
> + */
> + if ((1 << ffz(~mddev->chunk_size)) != mddev->chunk_size) {
> + printk(KERN_ERR "%s chunk_size of %d not valid\n",
> + mdname(mddev),
> + mddev->chunk_size);
> + return -EINVAL;
> + }
> if (mddev->reshape_position != MaxSector) {
> printk("raid1: %s: reshape_position set but not supported\n",
> mdname(mddev));
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
