On Tuesday May 19, raziebe@xxxxxxxxx wrote:
> have raid10 check chunk size in run method instead of in md
> raid10.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
> Signed-off-by: raziebe@xxxxxxxxx
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 2405add..52ad64e 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -2055,7 +2055,15 @@ static int run(mddev_t *mddev)
> "at least PAGE_SIZE(%ld).\n", PAGE_SIZE);
> return -EINVAL;
> }
> -
> + /*
> + * chunk-size has to be a power of 2
> + */
> + if ((1 << ffz(~mddev->chunk_size)) != mddev->chunk_size) {
> + printk(KERN_ERR "%s chunk_size of %d not valid\n",
> + mdname(mddev),
> + mddev->chunk_size);
> + return -EINVAL;
> + }
> nc = mddev->layout & 255;
> fc = (mddev->layout >> 8) & 255;
> fo = mddev->layout & (1<<16);
>
I combined this with the other chunk_size check in run, so there
is only the one printk.
Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
