Re: Subject: [PATCH 1/6] md: raid0 to compile when MD DEBUG is on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday May 19, raziebe@xxxxxxxxx wrote:
> Because of the removal the device list from 
> the strips raid0 did not compile with MD_DEBUG flag on.

Thanks, I had forgotten to check that!

>  
> -static void raid0_status (struct seq_file *seq, mddev_t *mddev)
> +static void raid0_status(struct seq_file *seq, mddev_t *mddev)
>  {
>  #undef MD_DEBUG
>  #ifdef MD_DEBUG
>  	int j, k, h;
>  	char b[BDEVNAME_SIZE];
>  	raid0_conf_t *conf = mddev->private;
> -
> +	sector_t zone_size;
> +	sector_t zone_start = 0;
>  	h = 0;
>  	for (j = 0; j < conf->nr_strip_zones; j++) {
>  		seq_printf(seq, "      z%d", j);
>  		seq_printf(seq, "=[");
>  		for (k = 0; k < conf->strip_zone[j].nb_dev; k++)
>  			seq_printf(seq, "%s/", bdevname(
> -				conf->strip_zone[j].dev[k]->bdev,b));
> -
> -		seq_printf(seq, "] ze=%d ds=%d s=%d\n",
> -				conf->strip_zone[j].zone_end,
> -				conf->strip_zone[j].dev_start,
> -				conf->strip_zone[j].sectors);
> +				conf->devlist[k]->bdev, b));
                                              ^

This doesn't look right.  There should a 'j' in there shouldn't there?
something like
                               conf->devlist[j*mddev->raid_disks + k]->bdev
??

> +
> +		zone_size  = conf->strip_zone[j].zone_end - zone_start;
> +		seq_printf(seq, "] ze=%lld ds=%lld s=%lld\n",
> +			(unsigned long long)zone_start>>1,
> +			(unsigned long long)conf->strip_zone[j].dev_start>>1,
> +			(unsigned long long)zone_size>>1);
> +		zone_start = conf->strip_zone[j].zone_end;

The rest looks fine.

Thanks,
NeilBrown


>  	}
>  #endif
>  	seq_printf(seq, " %dk chunks", mddev->chunk_size/1024);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux